Fix MatchError when printing match types from macros #13278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, type printing logic in `Extractors` and `SourceCode` lack a case for `MatchCase`. This means that attempting to print a match type (or any tree which contains a `TypeTree` with a match type) results in a `MatchError` being thrown. Adds cases for `MatchCase` to prevent this error.
nicolasstucki
approved these changes
Aug 12, 2021
|
Thank you @jeremyrsmith |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, type printing logic in
ExtractorsandSourceCodelack a case forMatchCase. This means that attempting to print a match type (or any tree which contains aTypeTreewith a match type) from a macro results in aMatchErrorbeing thrown. You can see this happen by running the included tests without the included fixes.Adds cases for
MatchCaseto prevent this error.